Re: [PATCH 2/3] Add gitmodules(5)

On Sun, Jun 10, 2007 at 10:58:29AM +0200, Lars Hjemli wrote:

On 6/10/07, Frank Lichtenheld [off-list ref] wrote:

quoted

quoted

+Each submodule can contain the following keys.
+
+module.$name.path::
+     Define a path, relative to the top-level directory of the git
+     working tree, where the submodule is expected to be checked out.
+
+module.$name.url::
+     Define a url from where the submodule repository can be cloned.

For .path a "Defaults to name of submodule" probably wouldn't hurt.

True. But there might be some issues with this rule, so I'll leave it
as is for now.

And what might those issues be?

How about adding something like

	For a given path relative to the top-level directory of the
	git working tree, the logical name of the submodule at that
	path (if any) is the submodule <name> with a module.<name>.path
	value equal to that path, or, if no such submodule exists, the
	submodule <path>.  It is an error for different submodules to have
	identical path values.

For uniformity, you may also want to specify that a path value
must (or must not) end with a slash.

Other than that, I like it.
It doesn't have the extensions proposed by Linus, but it seems
to be forward compatible with them.

skimo