Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH 1/7] Softrefs: Add softrefs header file with API documentation

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:43:15

Possibly related (same subject, not in this thread)

Hi,

On Sun, 10 Jun 2007, Junio C Hamano wrote:
Johannes Schindelin [off-list ref] writes:
quoted
Besides, your lines are way too long. Yes, it is not in 
Documentation/SubmittingPatches,...
... since you have to read the source to get acquainted 
with it _anyway_, it would only be a duplication to have it in 
SubmittingPatches, too.
Well, maybe we should do this.

[...]
But where to stop?

Many people want to put an opening curly bracket in its own line. Other 
indenting is subject for discussion, too. White space after operators, but 
not after function names should be included, too.

I know you mean good, but I think it is not a bad idea to let people get 
familiar with the code (and the formatting rules) first. This way we can 
even tell who did, and who did not do that, before submitting a patch.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help