Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH 16/21] Introduce optional "keywords" on tag objects

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:15

Possibly related (same subject, not in this thread)

"Alex Riesen" [off-list ref] writes:
On 6/9/07, Johan Herland [off-list ref] wrote:
quoted
This patch introduces a new optional header line to the tag object, called
"keywords". The "keywords" line may contain a comma-separated list of
custom keywords associated with the tag object.
What is the character set for the keywords?
quoted
+                       for (i = 0; i < keywords_len; ++i) {
+                               unsigned char c = keywords_line[i];
+                               if (c == ',' && keywords_line[i + 1] == ',')
+                                       /* consecutive commas */
+                                       return error("Tag object (@ char "
+                                               PD_FMT "): Found empty keyword",
+                                               keywords_line + i - data);
+                               if (c > ' ' && c != 0x7f)
+                                       continue;
And what is so special about 0x7f?
It is DEL, but as the code uses uchar, it probably also error on
0x80 or higher, if the intent is "printable ASCII".
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help