Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [PATCH 1/2] git-submodule: move cloning into a separate function

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:14

Possibly related (same subject, not in this thread)

"Lars Hjemli" [off-list ref] writes:
This is just a simple refactoring of modules_init() with no change in
functionality.

Signed-off-by: Lars Hjemli <redacted>
---

On Tue, 05 Jun 2007 12:40:50 +0200, Johannes Sixt [off-list ref] wrote:
quoted
Lars Hjemli wrote:
quoted
+               module_clone "$path" "$url" || exit $?
Minor nit: The idiom that is commonly used in situations like this (see
other git-* shell scripts):

		module_clone "$path" "$url" || exit

because exit without argument uses the code of the last command
executed.
Thanks, I'll follow up with matching changes to [patch 2/2].
This seems to be WS munged by your mailer.
quoted hunk
...
+	die "Clone of submodule '$path' failed"
+}
+
  #
  # Run clone + checkout on missing submodules
  #
@@ -40,20 +67,6 @@ modules_init()
  		# repository
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help