Re: Improved git-gui blame viewer

Alex Riesen [off-list ref] wrote:

On 6/2/07, Shawn O. Pearce [off-list ref] wrote:

quoted

I finally got the git-gui code to the point where cleaning up the
user interface was possible without sending myself to the nut house.

Very-very nice :) 

Thanks.  I'm not done yet.  There's a lot of interesting navigation
I still want to get in, like visting the parent of a changed line,
instead of the commit that changed that line.  I also want to let
you open commits in a new window, rather than the current one.

Does not seem to save sizes and positions of
blame and file browser windows, though. It did before, I believe
in .git/config.

Actually we have never saved the window sizes/positions of the 
blame and browser windows, only the main commit window.  Though
you may have been seeing a bug where we restored the main commit
window's saved geometry on a browser or blame window if the latter
was started from the command line...

BTW, saving windows positions in .git/config was scary: I
considered it user domain (yes, I _am_ afraid of using
git-config too).
Maybe it could be something like either ~/.git-gui or .git/guiconfig?

I'm apparently not afraid of git-config editing file(s).  I have
yet to see a failure from it.  I guess I'm lucky, but will now
suffer a failure tomorrow when I'm least expecting it.  ;-)

Don't we use git-config to edit the config file in git-branch?
In git-remote?  git-gui has *always* used git-config to store
its data.  You are sort of asking me to replace a working config
system with a new one that hasn't been tested...

Now moving the git-gui config to say ~/.gitgui-config and
.git/gitgui-config may have a good argument, as then git-gui
is editing its own files.  Unless the user changes user.name
or user.email through git-gui, in which case we have to edit
.git/config or ~/.gitconfig anyway...

-- 
Shawn.