Re: [PATCH] Unify write_index_file functions

On Fri, 1 Jun 2007, Dana How wrote:

(2) write_idx_file has a sha1 argument with different in & out meanings,
requiring copies at some call sites.  Should this be 2 separate args?

I think the copy could be avoided entirely.  The pack_file_sha1 array 
doesn't need to have global scope.  The simple sha1[20] array with this 
patch can serve the pack_file_sha1 purpose as well just fine.


Nicolas