Re: [PATCH] Add git-submodule command

On 5/25/07, Johannes Schindelin [off-list ref] wrote:

[* many usefull comments about the docs *]

Thanks, will fix

quoted

+USAGE='[--init | --update | --cached] [--quiet] [--] [<path>...]'
+. git-sh-setup
+require_work_tree

Maybe

        test -f "$GIT_DIR"/.gitmodules || die "Not a superproject"

Hmm?

Yeah, maybe. But the command will only touch entries with mode 160000
anyway, so it might not be a big deal.

quoted

+                     rmdir "$path" 2>/dev/null ||

Just out of curiousity: is rmdir portable? I always used "rm -r"...

I have no idea, really. But the reason for using rmdir was this
section of the man page:

NAME
       rmdir - remove empty directories

I do not want to delete an unempty directory. But there is probably
some better way to do this?

--
larsh