Thread (8 messages) flat view 8 messages, 3 authors, 2016-06-15

Re: [PATCH] Fix mishandling of $Id$ expanded in the repository copy in convert.c

From: Joshua N Pritikin <hidden>
Date: 2016-06-15 22:43:12

On Fri, May 25, 2007 at 11:50:08AM +0100, Andy Parkins wrote:
+			/*
+			 * Throw away characters until either
+			 *  - we reach a "$"
+			 *  - we run out of bytes (rem == 0)
+			 */
 			do {
-				ch = *cp++;
+				ch = *cp;
 				if (ch == '$')
 					break;
+				cp++;
 				rem--;
 			} while (rem);
Can this loop throw away newlines? Removing newlines seems like a bad 
idea.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help