Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] fix memory leak in parse_object when check_sha1_signature fails

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:12

"Shawn O. Pearce" [off-list ref] writes:
Carlos Rica [off-list ref] wrote:
quoted
When check_sha1_signature fails, program is not terminated:
it prints an error message and returns NULL, so the
buffer returned by read_sha1_file should be freed before.
...
quoted
		if (check_sha1_signature(sha1, buffer, size, typename(type)) 
		< 0) {
...

gmail strikes again.  The above line is wrapped, which means your
patch is whitespace damaged and won't apply properly.
That is only between your eyes, imagination and your MUA (hint:
"format: flowed").

For applying after saving it in mbox it does not pose a problem,
but it _does_ affect people who want to comment on the patch
while in MUA.

Is there a way to turn that "format: flawed" off?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help