Re: [PATCH] fix memory leak in parse_object when check_sha1_signature fails
From: Shawn O. Pearce <hidden> Date: 2016-06-15 22:43:12
Carlos Rica [off-list ref] wrote:
When check_sha1_signature fails, program is not terminated:
it prints an error message and returns NULL, so the
buffer returned by read_sha1_file should be freed before.
...
if (check_sha1_signature(sha1, buffer, size, typename(type))
< 0) {
...
gmail strikes again. The above line is wrapped, which means your
patch is whitespace damaged and won't apply properly.
--
Shawn.