Re: [PATCH] Prevent megablobs from gunking up git packs

Hi,

On Thu, 24 May 2007, Shawn O. Pearce wrote:

Junio C Hamano [off-list ref] wrote:

quoted

"Dana How" [off-list ref] writes:

quoted

The packed X too big combination is the problem.  As the
commit message says,  this could happen if the packs
came from fast-import,...
We have three options in this case:
(1) Drop the object (do not put it in the new pack(s)).
(2) Pass the object into the new pack(s).
(3) Write out the object as a new loose object.

Option (1) is unacceptable.  When you call git-repack -a,
it blindly deletes all the non-kept packs at the end.  So
the megablobs would be lost.

Ok, I can buy that -- (1) nor (2) are unacceptable and (3) is
the only sane thing to do for a previously packed objects that
exceed the size limit.

I still don't buy the idea that these megablobs shouldn't be packed.
I understand Dana's pain here (at least a little bit, my problems
aren't as bad as his are), but I also hate to see us run away from
packfiles for these really sick cases just because we have some
issues in our current packfile handling.

Isn't this issue helpable by the "-delta" attribute?

Ciao,
Dscho