Re: [PATCH] Cross-reference the manpages for git-name-rev and git-describe
From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:43:12
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH] Cross-reference the manpages for git-name-rev and git-describe · Shawn O. Pearce <hidden>
- 2016-06-15 · Re: [PATCH] Cross-reference the manpages for git-name-rev and git-describe · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH] Cross-reference the manpages for git-name-rev and git-describe · Shawn O. Pearce <hidden>
- 2016-06-15 · Re: [PATCH] Cross-reference the manpages for git-name-rev and git-describe · Matthieu Moy <hidden>
Junio C Hamano [off-list ref] wrote:
"Shawn O. Pearce" [off-list ref] writes:quoted
Teach git-describe how to run name-revSorry for a belated question, but is there a reason not to do this (on top)?
Nope, I just completely missed it. Please make it so! ;-)
quoted hunk ↗ jump to hunk
diff --git a/builtin-describe.c b/builtin-describe.c index efbd43f..2a32af6 100644 --- a/builtin-describe.c +++ b/builtin-describe.c@@ -283,8 +283,7 @@ int cmd_describe(int argc, const char **argv, const char *prefix) nr[2] = "--tags"; memcpy(nr + 3, argv + i, (argc - i) * sizeof(char*)); nr[3 + argc - i] = NULL; - execv_git_cmd(nr); - die("unable to start %s", nr[0]); + return cmd_name_rev(3 + argc - i, nr, prefix); } if (argc <= i)
-- Shawn.