Re: [PATCH 3/3] Use stringbuf to clean up some string handling code.

Alex Riesen [off-list ref] writes:

Timo Sirainen, Sun, May 20, 2007 04:25:42 +0200:

quoted

---
 commit.c      |   30 +++++++++++++-----------------
 local-fetch.c |   34 ++++++++++++++++------------------
 2 files changed, 29 insertions(+), 35 deletions(-)

I find it hard to believe that it actually was a cleanup.

It is a nicer code, but... it is bigger, heavier on stack, and it does
not actually fix anything.

In my experience, such changes are seldom worth the effort. It may be
a nice code (and I actually like str.[hc]), but its use _must_ be
justified. I.e. it must simplify a complex formatting routine, or fix
a bug, which otherwise would be too hard or ugly to fix. It is
definitely not the case in this patch.

Thanks.  I was kind of waiting for somebody to say that for me
;-)