Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [BUG] git-svn dcommit fails (connection closed unexpectedly)

From: Eric Wong <hidden>
Date: 2016-06-15 22:43:11

Possibly related (same subject, not in this thread)

Matthieu Moy [off-list ref] wrote:
"Lars Hjemli" [off-list ref] writes:
quoted
Is this happening if you dcommit a file in a new directory?
That's it indeed.

The attached script seems to reproducibly trigger the problem on my
box:

$ ../git-svn-test.sh
Checked out revision 0.
A         file
Adding         file
Transmitting file data .
Committed revision 1.
Initialized empty Git repository in .git/
moy@localhost's password: 
        A       file
r1 = 4357177f2d927931d31c8c49c0237561648001a7 (git-svn)

Checked out HEAD:
  svn+ssh://localhost//home/moy/tmp/test/test.26377/svnrepo r1
Created commit aa2db5a: newdir
 1 files changed, 1 insertions(+), 0 deletions(-)
 create mode 100644 newdir/newfile
moy@localhost's password: 
        A       newdir/newfile
Network connection closed unexpectedly: Connection closed unexpectedly at /home/moy/bin/local/verimag/git-svn line 405
$
Thanks to your script I can reproduce it.
svnserve (not git-svn) is segfaulting on me...
#! /bin/sh

mkdir test.$$
cd test.$$

svnadmin create svnrepo

svn co file://$PWD/svnrepo svnco

cd svnco
echo content > file
svn add file
svn commit -m "added file"
cd ../

# This triggers the bug.
git-svn clone svn+ssh://localhost/$PWD/svnrepo git-svn-co

# while this doesn't
# git-svn clone file://localhost/$PWD/svnrepo git-svn-co

cd git-svn-co

mkdir newdir
echo othercontent > newdir/newfile

git add newdir/newfile

git commit -m "newdir"

git-svn dcommit
Thanks.  I didn't realize entirely new directories (and not empty
directories in svn but git thought were new) were what was causing
things to break.

-- 
Eric Wong
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help