Thread (13 messages) flat view 13 messages, 4 authors, 2016-06-15

Re: [PATCH] Require JDK1.5

From: Grzegorz Kulewski <hidden>
Date: 2016-06-15 22:43:10

On Mon, 14 May 2007, Robin Rosenberg wrote:
This changes project settings to requre Java 5 and
also tightens some compiler settings.

Signed-off-by: Robin Rosenberg <redacted>
---
.../.settings/org.eclipse.jdt.core.prefs           |   22 ++++++++++---------
.../.settings/org.eclipse.jdt.ui.prefs             |    5 +--
.../.settings/org.eclipse.jdt.core.prefs           |   22 ++++++++++---------
.../.settings/org.eclipse.jdt.ui.prefs             |    5 +--
.../.settings/org.eclipse.jdt.core.prefs           |   22 ++++++++++---------
.../.settings/org.eclipse.jdt.ui.prefs             |    5 +--
.../.settings/org.eclipse.jdt.core.prefs           |   22 ++++++++++---------
.../.settings/org.eclipse.jdt.ui.prefs             |    3 +-
.../src/org/spearce/jgit/lib/ObjectIdMap.java      |    4 +-
9 files changed, 57 insertions(+), 53 deletions(-)
[snip]
quoted hunk ↗ jump to hunk
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectIdMap.java b/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectIdMap.java
index c397a0d..63796fd 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectIdMap.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectIdMap.java
@@ -50,9 +50,9 @@ public class ObjectIdMap implements Map {
	public ObjectIdMap(Map sample) {
		try {
-			Method m=sample.getClass().getMethod("clone", null);
+			Method m=sample.getClass().getMethod("clone", (Class[])null);
			for (int i=0; i<256; ++i) {
-				level0[i] = (Map)m.invoke(sample, null);
+				level0[i] = (Map)m.invoke(sample, (Object[])null);
			}
		} catch (IllegalAccessException e) {
			throw new IllegalArgumentException(e);
I wonder why one would need changes like this?

These casts are not needed for anything as far as I can see and your IDE 
should easily tell you what type that parameter is. No?


Thanks,

Grzegorz Kulewski
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help