[StGIT PATCH 3/5] Remove an unnecessary parameter to make_patch_name
From: Karl Hasselström <hidden>
Date: 2016-06-15 22:43:09
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Karl Hasselström <redacted> The "alternative" parameter was a boolean that indicated whether we were interested in testing if the first generated name was acceptable, or if we would just always accept it. But that can be accomplished by giving an "unacceptable" function that always returns False, so there's no need for an additional parameter. Signed-off-by: Karl Hasselström <redacted> --- stgit/commands/imprt.py | 8 +++++--- stgit/utils.py | 5 ++--- 2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/stgit/commands/imprt.py b/stgit/commands/imprt.py
index 89af472..6fcdc62 100644
--- a/stgit/commands/imprt.py
+++ b/stgit/commands/imprt.py@@ -242,9 +242,11 @@ def __create_patch(filename, message, author_name, author_email, patch = __strip_patch_name(patch) if not patch: - patch = make_patch_name(message, crt_series.patch_exists, - alternative = not (options.ignore - or options.replace)) + if options.ignore or options.replace: + unacceptable_name = lambda name: False + else: + unacceptable_name = crt_series.patch_exists + patch = make_patch_name(message, unacceptable_name) else: # fix possible invalid characters in the patch name patch = re.sub('[^\w.]+', '-', patch).strip('-')
diff --git a/stgit/utils.py b/stgit/utils.py
index 3612a4b..fbfe748 100644
--- a/stgit/utils.py
+++ b/stgit/utils.py@@ -183,15 +183,14 @@ def patch_name_from_msg(msg): subject_line = msg.split('\n', 1)[0].lstrip().lower() return re.sub('[\W]+', '-', subject_line).strip('-')[:30] -def make_patch_name(msg, unacceptable, default_name = 'patch', - alternative = True): +def make_patch_name(msg, unacceptable, default_name = 'patch'): """Return a patch name generated from the given commit message, guaranteed to make unacceptable(name) be false. If the commit message is empty, base the name on default_name instead.""" patchname = patch_name_from_msg(msg) if not patchname: patchname = default_name - if alternative and unacceptable(patchname): + if unacceptable(patchname): suffix = 0 while unacceptable('%s-%d' % (patchname, suffix)): suffix += 1