Re: [PATCH] Git.pm: config_boolean() -> config_bool()
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:09
Petr Baudis [off-list ref] writes:
So, I realized that I'm not sure again how to stick a mail reply and new patch version in the same mail - originally I wanted to reply to this mail and send the patch as another reply, but that seemed wasteful. Now it seems that the only option is to stuff the mail reply in the diffstat area, but I refuse to do that since that's just plainly stupid.
That's your opinion to go against a convention, which is fine, as long as you use something other than what begins with three dashes here as a separator.
quoted hunk
--- This patch renames config_boolean() to config_bool() for consistency with the commandline interface and because it is shorter but still obvious. ;-) It also changes the return value from some obscure string to real Perl boolean, allowing for clean user code. Signed-off-by: Petr Baudis <redacted> --- git-remote.perl | 4 ++-- git-send-email.perl | 4 ++-- perl/Git.pm | 14 +++++++++----- 3 files changed, 13 insertions(+), 9 deletions(-)diff --git a/git-remote.perl b/git-remote.perl index 52013fe..5763799 100755 --- a/git-remote.perl +++ b/git-remote.perl@@ -297,9 +297,9 @@ sub update_remote {