Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v2] Custom compression levels for objects and packs

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:09

"Dana How" [off-list ref] writes:
This doesn't interact well with each variable being processed
completely independently in git_config() and the callbacks it calls.
The isset() value is "out-of-band"; either store it in the _seen
variables, or some special value in used_value .

Which makes the most sense:
* Leave _seen as-is;
* Move pack.compression recognition into config.c which means
 the _seen variables would all be local to config.c;
* Use some special value, and if still present replace it with the default
 at the end of git_config() using extra code;
* Change the config rule to something simpler.

I like the 2nd and the 4th.  You didn't like the 4th.
Shall I change to the 2nd?
FWIW, I am Ok with (1).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help