Thread (29 messages) flat view 29 messages, 9 authors, 2016-06-15

Re: [PATCH] Add --no-reuse-delta, --window, and --depth options to git-gc

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:08

Possibly related (same subject, not in this thread)

Theodore Tso [off-list ref] writes:
On Mon, May 07, 2007 at 11:13:58PM -0400, Nicolas Pitre wrote:
quoted
... 
Especially if you're aware and interested in those options, you won't be 
afraid of 'git repack -a -f -d --window=...".

In the context of "gc", having an option that reads "window" looks a bit 
strange too.
I suppose, but you either need to then know all of the other commands
which git-gc runs, and do them manually, skipping git-gc altogether,
or use git-gc, and end up rewriting the pack twice,...
If the user really wants to tweak the parameters that much and
that often, I think what Nico says, plus your pack.depth/window
configuration variables, make more sense.  git-gc is meant to be
a shorthand with reasonable "one size fits all" default, and
there is something wrong if a user has to give customization
option every time it is run.  It could be that the default
parameters are grossly off for _everybody_, in which case we
should fix the default.

With the recent introduction of delta base caching code, we
might want to tweak the default pack depth to larger value for
everybody, by the way.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help