[PATCH] remove unnecessary loop
From: Liu Yubao <hidden>
Date: 2016-06-15 22:43:08
Subsystem:
the rest · Maintainer:
Linus Torvalds
Hi, Here is a minor optimization, the involved second "for" loop doesn't need to start from beginning. Signed-off-by: Liu Yubao <redacted> --- builtin-add.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/builtin-add.c b/builtin-add.c
index 5e6748f..9d10fdc 100644
--- a/builtin-add.c
+++ b/builtin-add.c@@ -239,20 +239,19 @@ int cmd_add(int argc, const char **argv, const char *prefix) die("index file corrupt"); if (!ignored_too) { - int has_ignored = 0; for (i = 0; i < dir.nr; i++) if (dir.entries[i]->ignored) - has_ignored = 1; - if (has_ignored) { + break; + if (i < dir.nr) { fprintf(stderr, ignore_warning); - for (i = 0; i < dir.nr; i++) { + do { if (!dir.entries[i]->ignored) continue; fprintf(stderr, "%s", dir.entries[i]->name); if (dir.entries[i]->ignored_dir) fprintf(stderr, " (directory)"); fputc('\n', stderr); - } + } while (++i < dir.nr); fprintf(stderr, "Use -f if you really want to add them.\n"); exit(1);
--
1.5.2.rc0.95.ga0715-dirty