Re: [PATCH v3] Support ent:relative_path

5 messages, 3 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH v3] Support ent:relative_path

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:08

Martin Waitz [off-list ref] writes:
we could also introduce "<tree-ish>/<path>" for absolute path entries.
When you name the tree-ish with usual "branch name", where does
the branch name end and pathname start?  What happens when there
is an ambiguity, and how costly to detect such an ambiguity to
begin with?

Re: [PATCH v3] Support ent:relative_path

From: Martin Waitz <hidden>
Date: 2016-06-15 22:43:08

hoi :)

On Sat, May 05, 2007 at 01:17:35PM -0700, Junio C Hamano wrote:
quoted
we could also introduce "<tree-ish>/<path>" for absolute path entries.
When you name the tree-ish with usual "branch name", where does
the branch name end and pathname start?  What happens when there
is an ambiguity, and how costly to detect such an ambiguity to
begin with?
well, if you know that it starts with a tree-ish there is no
ambiguity as there can't be any "a/b" tree-ish if there already is one
named "a".  But Alex is right, it can be confused with an relative
path if e.g. git-log is used without "--".

But for submodules I'd really like the / syntax.

-- 
Martin Waitz

Re: [PATCH v3] Support ent:relative_path

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:43:08

Hi,

On Sat, 5 May 2007, Martin Waitz wrote:
hoi :)

On Sat, May 05, 2007 at 01:17:35PM -0700, Junio C Hamano wrote:
quoted
quoted
we could also introduce "<tree-ish>/<path>" for absolute path entries.
When you name the tree-ish with usual "branch name", where does
the branch name end and pathname start?  What happens when there
is an ambiguity, and how costly to detect such an ambiguity to
begin with?
well, if you know that it starts with a tree-ish there is no
ambiguity [...]
Wrong. For example, mw/submodules~10 _is_ a tree-ish (if you have a branch 
named "mw/submodules").

Hth,
Dscho

Re: [PATCH v3] Support ent:relative_path

From: Martin Waitz <hidden>
Date: 2016-06-15 22:43:08

hoi :)

On Sun, May 06, 2007 at 02:59:55AM +0200, Johannes Schindelin wrote:
quoted
On Sat, May 05, 2007 at 01:17:35PM -0700, Junio C Hamano wrote:
quoted
quoted
we could also introduce "<tree-ish>/<path>" for absolute path entries.
When you name the tree-ish with usual "branch name", where does
the branch name end and pathname start?  What happens when there
is an ambiguity, and how costly to detect such an ambiguity to
begin with?
well, if you know that it starts with a tree-ish there is no
ambiguity [...]
Wrong. For example, mw/submodules~10 _is_ a tree-ish (if you have a branch 
named "mw/submodules").
so what?

a better argument is that one can have both refs/tags/a and
refs/heads/a/b.

So just forget my suggestion...

-- 
Martin Waitz

Re: [PATCH v3] Support ent:relative_path

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:43:08

Hi,

On Sun, 6 May 2007, Martin Waitz wrote:
On Sun, May 06, 2007 at 02:59:55AM +0200, Johannes Schindelin wrote:
quoted
quoted
On Sat, May 05, 2007 at 01:17:35PM -0700, Junio C Hamano wrote:
quoted
quoted
we could also introduce "<tree-ish>/<path>" for absolute path entries.
When you name the tree-ish with usual "branch name", where does
the branch name end and pathname start?  What happens when there
is an ambiguity, and how costly to detect such an ambiguity to
begin with?
well, if you know that it starts with a tree-ish there is no
ambiguity [...]
Wrong. For example, mw/submodules~10 _is_ a tree-ish (if you have a branch 
named "mw/submodules").
so what?
So what: it proves that your case is wrong. mw/submodules~10/README would 
be _severely_ confused.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help