Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] Make xstrndup common

From: Alex Riesen <hidden>
Date: 2016-06-15 22:43:08

On 5/3/07, Daniel Barkalow [off-list ref] wrote:
+static inline char *xstrndup(const char *str, int len)
+{
+       char *ret;
+       int i;
+       for (i = 0; i < len && str[i]; i++)
+               ;
+       ret = xmalloc(i + 1);
+       strncpy(ret, str, i);
+       ret[i] = '\0';
+       return ret;
+}
I'd suggest using platform-optimized memchr:

static inline char *xstrndup(const char *s, int len)
{
    char *p = memchr(s, 0, len);
    int n = p ? p - s: len;
    p = xmalloc(n + 1);
    memcpy(p, s, n);
    p[n] = '\0';
    return p;
}
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help