Re: [PATCH 1/5] Introduces for_each_revision() helper

"Luiz Fernando N. Capitulino" [off-list ref]
writes:

Em Fri, 27 Apr 2007 12:32:11 -0700
Junio C Hamano [off-list ref] escreveu:

| "Luiz Fernando N. Capitulino" [off-list ref]
| writes:
| 
| > From: Luiz Fernando N. Capitulino [off-list ref]
| >
| > This macro may be used to iterate over revisions, so, instead of
| > doing: ...
| 
| I am not a big fan of magic control-flow macros, as it makes the
| code harder to grok for people new to the codebase.

 Yeah, I agree. But I think that any experienced programmer will
understand it.

 Anyways, I don't want to raise polemic discussions for minor
changes. Feel free to drop this one then.

I on the other hand like the kernel style list macros.

The reason I do not like this particular one is because both
operations you are hiding are not simple operations like
"initialize a variable to list head" or "follow a single pointer
in the structure", but rather heavyweight operations with rather
complex semantics.  I would want to make sure that people
realize they are calling something heavyweight when they use the
revision traversal.