Re: [PATCH 3/5] Use remote functions in git-push
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:07
Daniel Barkalow [off-list ref] writes:
quoted hunk
diff --git a/builtin-push.c b/builtin-push.c index cb78401..2e944cd 100644 --- a/builtin-push.c +++ b/builtin-push.c@@ -5,6 +5,7 @@ #include "refs.h" #include "run-command.h" #include "builtin.h" +#include "remote.h"
As I am rejecting the initial round of [PATCH 2/5], I only gave a cursory look at this one, but it seems straightforward code shuffling and nothing controversial. I however would have liked a patch that moves bulk of remote parsing code from builtin-push.c to remote.c without adding anything that builtin-push.c did not have (i.e. fetch refspecs handling). That is, half of [PATCH 2/5] and this patch should have been a single patch that says "this moves code from builtin-push.c to remote.c, while abstracting out the static variables into struct remote, without doing anything else". Then later you enhance the remote.c interface to deal with fetch refspecs and stuff in separate patches.
#define MAX_URI (16)
I do not think you need this anymore...