Re: [PATCH] git-svn: Don't rely on $_ after making a function call
From: Randal L. Schwartz <hidden>
Date: 2016-06-15 22:43:07
quoted
quoted
quoted
quoted
"Junio" == Junio C Hamano [off-list ref] writes:
Junio> I suspect Merlyn has better explanation, but...
Junio> for (list) {
Junio> ...
Junio> }
Junio> loop implicitly localizes $_ and does not share this problem,
Junio> which I really appreciate whenever I am writing Perl code, but
Junio> often enough I was bitten by scripts that use "while (<$fh>)",
Junio> which does not localizes $_, and made hard to spot bugs by
Junio> clobbering $_.
Junio> I find the patch a good safety measure for any future breakages.
I'm happy with the patch.
--
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
[off-list ref] <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!