Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Fix handle leak in write_tree

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:07

Alex Riesen [off-list ref] writes:
Then let the top level call something like

    git_cleanup(struct git_context *);

in its _own_ signal or atexit handlers. If it didn't setup the
handlers, than perhaps it did want it so (leaving tempfiles behind is
sometimes done on purpose). Or it _is_ a bug, but then it is clear:
you have to cleanup, and you do git's part of cleanup with
git_cleanup.
I would agree that libification would need to go something along
that line.

In the meantime for 1.5.2 stabilization, let's do the minimum
fix of applying your earlier patch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help