Thread (4 messages) flat view 4 messages, 2 authors, 2016-06-15

Re: [BUG] git gui and my ö

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:43:06

"Shawn O. Pearce" [off-list ref] wrote:
Uwe Kleine-K??nig [off-list ref] wrote:
quoted
	commit-tree failed:
	Warning: commit message does not conform to UTF-8.
This was starting to bug me, so I went off and found it.  OK, well
the encoding error anyway.  git-gui incorrectly claimed commit-tree
failed when it didn't.  But besides the point, this is the bad line:
   1294     fconfigure $msg_wt -encoding $enc -translation binary
I have had trouble in the past with trying to use that magic
-encoding flag on fconfigure to get Tcl's file channels to perform
encoding work for me.  Seems it doesn't work right or something...
so other parts of git-gui (e.g. the filename handling parts)
perform the convertfrom/convertto logic on their own... but the
commit message handling parts didn't.

They do now (git gui 0.6.5-11-gf20db5f).

Can you please test my current master branch and see if that fixes
things for you?  repo.or.cz, git-gui.git...

If it does, I'm probably going to tag that as 0.6.6 and let Junio
cut 1.5.2 with that release.

-- 
Shawn.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help