Re: [PATCH] Fix crash in t0020 (crlf conversion)

Alex Riesen, Sun, Apr 22, 2007 16:11:54 +0200:

Reallocated wrong size.
Noticed on Ubuntu 7.04 probably because it has some malloc diagnostics in libc:
"git-read-tree --reset -u HEAD" aborted in the test. Valgrind sped up the
debugging greatly: took me 10 minutes.

Alex Riesen, Sun, Apr 22, 2007 16:12:22 +0200:

Also, noticed by valgrind: the code caused a read out-of-bounds.
Some comments updated as well (they still reflected old calling
conventions).

Actually, it is all the other way around. The _second_ patch
(buffer->src in convert.c, the read out-of-bounds caused overwrite of
malloc control structures because of incorrect dst update condition)
is for the crash, the first is unrelated, but noticed by valgrind
in the same test.

I messed up the commit descriptions completely (Martins mail made
me look at the patches again). Sorry