Re: [PATCH 2/7] gitweb: Support comparing blobs with different names

Jakub Narebski [off-list ref] writes:

Currently we have:

  $ git diff -p HEAD^ HEAD -- gitweb/test/hardlink
  diff --git a/gitweb/test/hardlink b/gitweb/test/hardlink
  old mode 100644
  new mode 100755

but

  $ git diff -p HEAD^:gitweb/test/hardlink HEAD:gitweb/test/hardlink

returns empty diff.

By "blobdiff", I understand you are talking about the "diff"
link that appears on each path at the bottom of the commit view.

I think the bug is the way gitweb drives the core; it uses the
latter form, when it has perfectly good information to run the
former.  It's not like you have an UI that says "pick any path
from any comit first; after you have picked one, pick the other
arbitrary one; now we run compare them".  The UI says "Give me
diff for this path in this commit".