Thread (8 messages) flat view 8 messages, 5 authors, 2016-06-15

Re: [PATCH 1/2] Custom low-level merge driver support.

From: Johannes Sixt <hidden>
Date: 2016-06-15 22:43:05

Junio C Hamano wrote:
+       interpolate(cmdbuf, sizeof(cmdbuf), cmd, table, 3);
+
+       memset(&child, 0, sizeof(child));
+       child.argv = args;
+       args[0] = "sh";
+       args[1] = "-c";
+       args[2] = cmdbuf;
+       args[3] = NULL;
If I read the code correctly, there does not happen any shell quoting
anywhere; hence, this shell invocation is dangerous.

-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help