Re: [PATCH 2/2] Add keyword unexpansion support to convert.c
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:05
"Robin H. Johnson" [off-list ref] writes:
Glancing at the Gentoo bugs I've dealt with over the last 2 months as a quick survey, there are a few levels: A - Able to submit a good diff B - Able to do a good implementation C - Able to come up with a good idea for improvement B are in short supply, and even of those, the number that can do A are smaller :-(. Category C is vastly bigger than B, and those that don't make B throw up a lot of chaff of bad implementations. Being able to extract the good ideas is what's important.
True, to a certain degree. Maybe you and your fellow Gentoo people are very much more accomodating, but my fear is that a maintainer that goes length to sift through chaff himself quickly runs out of time, becomes exhausted, and ends up being careless. Maybe I am spoiled by having only the best people around me, and on git list. But we are straying to a tangent. I do not have much against an optional "only blob id" expansion myself, as I do not see any more downside than CRLF expansion in it. But I suspect that once people see the $id$ expanded to blob, they would not stop, because simply they do not understand why blob-id and CRLF are much less evil than other things.