Thread (11 messages) flat view 11 messages, 7 authors, 2016-06-15

Re: [PATCH 2/2] Add keyword unexpansion support to convert.c

From: Johannes Sixt <hidden>
Date: 2016-06-15 22:43:05

Andy Parkins wrote:
        switch (git_path_check_crlf(path)) {
        case 0:
-               return 0;
+               changes += 0;
        case 1:
-               return forcecrlf_to_git(path, bufp, sizep);
+               changes += forcecrlf_to_git(path, bufp, sizep);
        default:
-               return autocrlf_to_git(path, bufp, sizep);
+               changes += autocrlf_to_git(path, bufp, sizep);
+       }
+
+       switch (git_path_check_keyword(path)) {
+       case 0:
+               changes += 0;
+       case 1:
+               changes += keyword_unexpand_git(path, bufp, sizep);
        }
I think there are 'break's missing all along the way.

-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help