Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Correct dir.c to compile on Solaris 9

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:04

Robin Rosenberg [off-list ref] writes:
quoted hunk
The table lookup *is* faster (meastured), but that doesn't make a big difference
on the total CPU used. The muliple-case-per line thing (both versions, however makes is hard
to read.  

-- robin
diff --git a/dir.c b/dir.c
index 7426fde..0780f23 100644
--- a/dir.c
+++ b/dir.c
@@ -423,12 +423,22 @@ static int cmp_name(const void *p1, const void *p2)
  */
 static int simple_length(const char *match)
 {
-       const char special[256] = {
-               [0] = 1, ['?'] = 1,
-               ['\\'] = 1, ['*'] = 1,
-               ['['] = 1
-       };
        int len = -1;
+       static const char special[256] = {
+               1,0,0,0,0,0,0,0, /* nul */
+               0,0,0,0,0,0,0,0,
+               0,0,0,0,0,0,0,0,
+               0,0,0,0,0,0,0,0,
+               0,0,0,0,0,0,0,0,
+               0,0,1,0,0,0,0,0, /* * */
I wonder if folding this into ctype.c::sane_ctype[] is an
option...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help