Re: Expose subprojects as special files to "git diff" machinery

On Sun, Apr 15, 2007 at 12:05:44PM -0700, Linus Torvalds wrote:

On Sun, 15 Apr 2007, Sam Ravnborg wrote:

quoted

quoted

 
+static int diff_populate_gitlink(struct diff_filespec *s, int size_only)
+{
+	int len;
+	char *data = xmalloc(100);
+	len = snprintf(data, 100,
+		"Subproject commit %s\n", sha1_to_hex(s->sha1));

In userland I would use a local variable for an array of the size of 100.
I would normally only allocate when we are say 5x bigger.

We're _returning_ the pointer to the caller, so no, we cannot use an 
automatic array.

Do not know how I missed that...
Thanks,
	Sam