Re: [PATCH 1/3] Add basic infrastructure to assign attributes to paths

Andy Parkins [off-list ref] writes:

quoted

parent directories.  Lines in $GIT_DIR/info/attributes file are
used as the lowest precedence default rules.

Shouldn't this be the highest precedence?  This would be important for 
those cases where I (as a fringe developer) disagree with an attribute 
that's been assigned in-tree.  I don't want to force my will on every 
other developer, but would want my repository to work how I like it.  

Johannes Sixt [off-list ref] writes:

quoted

This makes paths with 'nodiff' attribute not to produce
"textual" diffs from 'git-diff' family.

If saying "nodiff" can be made equivalent to "!diff", then I'd strongly
prefer an attribute "diff" over "nodiff". I'm a strong disbeliever in
double negation.

Both of these are good points.

The only reason I initially made it 'nodiff' was to have a pair
of examples to demonstrate positive and negative setting of
attributes, and I agree it makes more sense to say 'diff' in
positive.

I reshuffled the code to make $GIT_DIR/info/attributes the
highest precedence, and unsetting 'diff' attribute to disable
diff; the result is in 'next'.

I'll follow this message up with a few more patches in the
series.