Thread (3 messages) flat view 3 messages, 1 author, 2016-06-15

Re: [PATCH 2/2] Teach "git-read-tree -u" to check out submodules as a directory

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2016-06-15 22:43:04


On Thu, 12 Apr 2007, Linus Torvalds wrote:
[ Side note: this also shows that we currently don't correctly handle
  such subprojects that aren't checked out correctly yet.  They should
  always show up as not being modified, but failing to resolve the
  gitlink HEAD does not properly trigger the "not modified" logic in all 
  places it needs to..

  So more work to be done, but that's a separate issue, unrelated to
  the action of checking out the superproject. ]
Apart from this issue, and the fact that we don't actually diff 
subprojects at all right now (even to the point of saying "subproject XyZ 
has changed from commit X to commit Y" - the raw format knows to say that, 
but the patch format does not), I think the "really core plumbing" is 
actually mostly done with this series.

So there's certainly some loose ends to tie up and some missing 
functionality even at the core level, but I suspect this is getting to the 
point where a big chunk of the remaining part is actually to teach the 
upper layers (like "fetch", "checkout", "merge" etc) to actually iterate 
over subprojects using the theoretical higher-level ".subprojects" file, 
and do the plumbing-level operations on those.

Of course, actually trying to start to *use* these things is bound to find 
tons and tons of issues, but I still feel like a lot of the core is at 
least "fleshed out", if not necessarily actually usable yet.

I may take a few days off on this, and hope others will step in and fix up 
some of the remaining problems ..

			Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help