Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH 1/8] git-repack --max-pack-size: Add new file statics and struct fields

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:03

Dana How [off-list ref] writes:
... The fields
in object_entry are re-arranged & shrunk to save memory.
Is the driving principle "place fields with coarser alignment
requirements first in the struct"?  I noticed you have a handful
pointers and an off_t after two short fields.  Two shorts would
be likely to make the next field aligned suitable for an int,
but (1) if we ever add another short later that would not be
true anymore, and (2) I suspect a pointer and an off_t can be
longer than an int but int would never be longer than them.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help