Thread (5 messages) flat view 5 messages, 3 authors, 2016-06-15

Re: [PATCH] Add --with-tcltk and --without-tcltk to configure.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:02

Possibly related (same subject, not in this thread)

Eygene Ryabinkin [off-list ref] writes:
Or you meant something different? I am little confused with
the '$PATH' in your example. Was it intended?
Yes, the dollar-sign-in-pathname is pretty much a part of my
pathological example. 
quoted
But come to think of it, it lets shell handle $PATH to find wish
anyway, so *unless* we have specific version dependency to wish
that wish binary normally found on user's $PATH is inadequate,
we probably should not even need to be doing any of this path
munging.  You might end up discovering the path to wish binary
in your autoconf script, we do not have to use it.  ./configure
can just see if there is wish, and set NO_TCLTK appropriately
without any of the path business.

What do you think?
There are problems at least with FreeBSD: it just installs the
wish8.4, wish8.3, wish8.2, etc. It does not provide the bare 'wish'
as the link to one of those.
Then sed -e 's/wish/$(WISH_NAME)/', still letting the shell to
handle the path part, could be a simpler option.  I dunno.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help