Re: [PATCH 1/2] Documentation: Allow @@GIT_VERSION@@ in asciidoc.conf

On Fri, Mar 23, 2007 at 02:53:58PM -0700, Junio C Hamano wrote:

Frank Lichtenheld [off-list ref] writes:

quoted

Rename asciidoc.conf to asciidoc.conf.in and create
the former on build time after piping it through sed.

This is useful to allow us to include the git version
in the documentation.

When sending a patch like this, please use "format-patch -M".

Ok.

While this is attractive to some degree, *I* am grumpy.  Doesn't
this patch make html and man branches update all files _every_
time any small change is made to some documentation?

Not with my patch; which is a bug in the patch though because
asciidoc.conf should really depend on GIT-VERSION-FILE.

Another possibility would be to replace the @@GIT_VERSION@@ in the man pages
themself and not in the asciidoc.conf. This would mean perhaps slightly
bigger changes to the build system, but running sed on all the files is of
course a lot faster than regenerating them with asciidoc.

What do you think?

Gruesse,
-- 
Frank Lichtenheld [off-list ref]
www: http://www.djpig.de/