Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: Errors pushing tags in "next"

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:01

Marco Roeland [off-list ref] writes:
quoted
Luben Tuikov [off-list ref] writes:
quoted
BTW, git has always said to me "Pushing version ... to the masses"
whenever I'd do "git-push --tags web".
Sorry, I must be blind, and git-grep is too.

$ git grep -e 'to the masses' -e 'Pushing v'

returns absolutely empty.
The line comes from an older version of templates/hooks--update. The
line was removed in commit 829a686f1b50ba96cac2d88494fa339efe0c0862 .

So Luben does seem to have a hook installed, perhaps this is the
culprit.
Thanks for spotting this.  I do not use this hook (well, I only
use commit-msg, pre-commit, and pre-rebase patches) and it was
totally outside of my radar.

It runs describe to find the previous tag, but the parser is a
bit old fashioned.  It says:

	prev=$(git describe "$3^" | sed 's/-g.*//')

but modern way to say the same is:

	prev=$(git describe --abbrev=0 "$3^")

Luben, sorry for the trouble.

I do not know how much better the recent hooks--update is
compared to the version you use.  It is supposed to be backward
compatible, so you _might_ want to simply update it with the one
from 'master' after checking if it suits your needs.  Otherwise,
I think the above one-liner should work the problem around.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help