Re: [PATCH] git-bundle: fix pack generation.
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:58
Johannes Schindelin [off-list ref] writes:
quoted
git-bundle create test.bdl HEAD --since=1.day.ago ==>> pack with 1531 objectsDid you test with "--since=1.day.ago HEAD", i.e. with the correct order? I know you'd like the options to be interminglable, but "HEAD" really is not an option, but an argument.
That is probably true but I do not think we have ever had date limiter and --objects interact correctly. It is understandable as traditionally packs were to generate needed objects between revisions, and unlimited but counted (--max-count) or timed (--max-age) are unexpected uses for "rev-list --objects" (in other words, nobody had done so and I am not surprised it does not work as you expect -- rather I would be surprised if anybody has even expectd the current code to work that way without modification). I am a bit too tired tonight so anybody is welcome to beat me to fix this one, preferrably on top of 'next'.