Re: [PATCH] gitweb: Change to use explicitly function call cgi->escapHTML()
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:58
Jeff King [off-list ref] writes:
On Tue, Mar 06, 2007 at 10:34:32AM +0100, Jakub Narebski wrote:quoted
quoted
Regardless of the recent xhtml+html vs html discussion, I think this is probably a sane change. Comments?Good (although a bit magic) solution. Ack, FWIW.I think this should do the same, and is perhaps less magic (or maybe more, depending on your perspective). -Peff
Thanks. I tend to agree, as it does not depend on the reader knowing what magic $cgi default behaviour is by being expliicit.
quoted hunk
-- >8 --diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 653ca3c..5d1d8cf 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl@@ -17,6 +17,7 @@ use Fcntl ':mode'; use File::Find qw(); use File::Basename qw(basename); binmode STDOUT, ':utf8'; +CGI::autoEscape(1); BEGIN { CGI->compile() if $ENV{MOD_PERL};