Re: [PATCH 3/4] git-bundle: various fixups
From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:42:58
Hi, On Mon, 5 Mar 2007, Junio C Hamano wrote:
verify_bundle() returned with an error early only when all prerequisite commits were missing. It should error out much earlier when some are missing.
The idea was to list _all_ missing prerequisites so that git-bundle will not complain _again_, about different missing prerequisites, when the first set of missing prerequisites was obtained. The check only prevented looking for _reachable_ commits, when none of the prerequisites were found in the object database to begin with.
When the rev-list is limited in ways other than revision range (e.g. --max-count or --max-age), create_bundle() listed all positive refs given from the command line as if they are available, but resulting pack may not have some of them. Add a logic to make sure all of them are included, and error out otherwise.
Good catch! Ciao, Dscho