Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 5/7] Try to do things in the right order

From: Xavier Maillard <hidden>
Date: 2016-06-15 22:42:58

   From: Alexandre Julliard [off-list ref]

   Xavier Maillard [off-list ref] writes:

   > @@ -35,8 +36,14 @@
   >    (require 'vc)
   >    (require 'cl))
   >  
   > -;; Add it automatically
   > -(add-to-list 'vc-handled-backends 'GIT)
   > +;; HACK: clear up the cache to force vc-call to check again and
   > +;; discover new functions when we reload this file.
   > +(put 'GIT 'vc-functions nil)
   > +
   > +;; Add it automatically when loading vc
   > +;; FIXME: should be directly put into vc.el
   > +(eval-after-load "vc"
   > +  '(add-to-list 'vc-handled-backends 'GIT))

   That's ugly. Simply recommending that users set vc-handled-backends in
   their .emacs is easier and cleaner, I still don't see why you want to
   change it.

I'd rather want to just require or load vc-git (and that should
not be the way to go too since it should be automatically handled
by vc.el when vc-git will become part of GNU Emacs ).

By the way, do you plan to ask for inclusion into emacs ?

That's just a matter of taste, nothing more.

-- 
Xavier
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help