Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 6/7] Small changes

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:58

Xavier Maillard [off-list ref] writes:
* Makefile: add git-blame as a candidate to the
  byte-compilation. Change the function to call to byte-compile.
Could we have a bit more detailed description on the latter
change?

Explaining why something needed a change is the point of a
commit log message.  Summarizing what got changed and how is
good but that is secondary, because anybody can see that you
changed the handcrafted --eval to -f by running "git show", even
if you did not have the above proposed log message.

What is left unsaid is _why_ it is better to use single dash
form of "-batch" and -f form instead of handcrafted --eval, and
the proposed log message does not clarify the reason.
 %.elc: %.el
-	$(EMACS) --batch --eval '(byte-compile-file "$<")'
+	$(EMACS) -batch -f batch-byte-compile $<
 
 clean:; rm -f $(ELC)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help