[PATCH 2/2] Tell multi-parent diff about core.symlinks.
From: Johannes Sixt <hidden>
Date: 2016-06-15 22:42:58
Subsystem:
the rest · Maintainer:
Linus Torvalds
When core.symlinks is false, and a merge of symbolic links had conflicts, the merge result is left as a file in the working directory. A decision must be made whether the file is treated as a regular file or as a symbolic link. This patch treats the file as a symbolic link only if all merge parents were also symbolic links. Signed-off-by: Johannes Sixt <redacted> --- I'm not quite sure whether this patch is worth it. The only thing it seems to do is to avoid the mode change line (this is after a merge where 'symlink' had a conflict): without the patch: $ git diff diff --cc symlink index 1a010b1,30d67d4..0000000 mode 120000,120000..100644 --- a/symlink +++ b/symlink with the patch: $ git diff diff --cc symlink index 1a010b1,30d67d4..0000000 --- a/symlink +++ b/symlink combine-diff.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/combine-diff.c b/combine-diff.c
index 044633d..e6e3969 100644
--- a/combine-diff.c
+++ b/combine-diff.c@@ -699,8 +699,18 @@ static void show_patch_diff(struct combine_diff_path *elem, int num_parent, !fstat(fd, &st)) { size_t len = st.st_size; size_t sz = 0; + int is_file, i; elem->mode = canon_mode(st.st_mode); + /* if symlinks don't work, assume symlink if all parents + * are symlinks + */ + is_file = has_symlinks; + for (i = 0; !is_file && i < num_parent; i++) + is_file = !S_ISLNK(elem->parent[i].mode); + if (!is_file) + elem->mode = canon_mode(S_IFLNK); + result_size = len; result = xmalloc(len + 1); while (sz < len) {
--
1.5.0.2.4.gdd4e4-dirty