Re: [PATCH] Update tests to use test-chmtime

Hi,

On Sat, 24 Feb 2007, Junio C Hamano wrote:

Eric Wong [off-list ref] writes:

quoted

-case "$(date -d @11111111 +%s 2>/dev/null)" in
-11111111)
...
-	touch -m -t "$predate1" $rr/preimage
-	touch -m -t "$predate2" $rr2/preimage
...
-esac
+now=$(date +%s)
+almost_15_days_ago=$(($now+60-15*86400))
+just_over_15_days_ago=$(($now-1-15*86400))
+almost_60_days_ago=$(($now+60-60*86400))
+just_over_60_days_ago=$(($now-1-60*86400))
+
+test-chmtime =$almost_60_days_ago $rr/preimage
+test-chmtime =$almost_15_days_ago $rr2/preimage

Very nice.
I've been wanting to get rid of this part for quite a while.

However, is '+%s' output portable enough for this change to be
an improvement?

It is not portable, but according to the man page:

	%s seconds since 00:00:00, Jan 1, 1970 (a GNU extension)

I would suggest changing "test-chmtime =-200 file" to set the mtime of 
the file to 200 seconds in the past, relative to present.

I wanted to propose the same, but without a patch :-)

Ciao,
Dscho