Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] disable t4016-diff-quote.sh on some filesystems

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:56

"Alex Riesen" [off-list ref] writes:
because the filesystems (most typically FAT and NTFS) do not support
HT nor LF in filenames.

Signed-off-by: Alex Riesen <redacted>

---
God help me...

 t/t4016-diff-quote.sh |    4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
Buddha help me.

You are still lacking the "good stuff" in what I'd end up saving
in a separate file and applying, which is the attachment part...
From 0edbc6df977e7d954032eaf72720c93b86ab4c0f Mon Sep 17 00:00:00 2001
From: Alex Riesen <redacted>
Date: Tue, 20 Feb 2007 10:04:32 +0100
Subject: [PATCH] disable t4016-diff-quote.sh on some filesystems

---
 t/t4016-diff-quote.sh |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
... but that is a minor detail.  I can survive.
+if ! test : 2>/dev/null >"$P1" ; then
+	echo >&2 'Filesystem does not support tabs in names'
+	test_done
+fi
I do not understand what this test-colon is doing?  Did you mean

	if ! : >"$P1" 2>&1
        then
		...
	fi

I would have written it like this, to check if it really
succeeded creating and also we can remove it.

	: >"$P1" 2>&1 && test -f "$P1" && rm -f "$P1" || {
		...
	}
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help