Re: [PATCH] Support for large files on 32bit systems.

On Sat, 17 Feb 2007, Shawn O. Pearce wrote:

Martin Waitz [off-list ref] wrote:

quoted

arg, this patch is completely broken.
I tested it by setting the macro via the command line and the
= is still left in there.  And __GLIBC__ is not yet defined at this
point.

However, we need to set _FILE_OFFSET_BITS for glibc somehow.
What is the best way to do so?

I think the only way to do with this is to have the Makefile detect
if -D_FILE_OFFSET_BITS=64 is required to be added to CFLAGS based on
some rule (e.g. uname output?), then add that to CFLAGS when needed.

Why not simply defining _FILE_OFFSET_BITS=64 unconditionally?

It certainly won't cause GIT to explode if compiled against something 
else than glibc.


Nicolas