Re: [PATCH] Read cvsimport options from repo-config
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:52
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH] Read cvsimport options from repo-config · James Bowes <hidden>
I find what your patch does quite sensible, although the split(/ *(?!:)/) magic might be a bit hard to read for the uninitiated.
+ my $arg = 'git-repo-config';
+ $arg .= ' --bool' if ($o !~ /:$/);
+
+ chomp(my $tmp = `$arg --get cvsimport.$key`);
+ if ($tmp && !($arg =~ / --bool / && $tmp eq 'false')) {Can this =~ / --bool / ever match (note the SP after 'l')?